Issue 5339001: Add a regexp to verify the host parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5339001: Add a regexp to verify the host parameter. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
truty

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add a regexp to verify the host parameter. If the host parameter is invalid, like having a trailing backslash, it will result on HTTP 400 later which is much harder to diagnose. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67295

Patch Set 1 #

Patch Set 2 : Improve regexp to support port number #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	third_party/upload.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Patch is being upstreamed at http://codereview.appspot.com/3279041

10 years, 1 month ago (2010-11-23 16:21:05 UTC) #1

truty

10 years, 1 month ago (2010-11-23 17:16:59 UTC) #2

lgtm (and I tested this by adding a trailing backslash to the rietveldserver for
the current issue in .git/config).

Expand Messages | Collapse Messages