Issue 5338005: Fix number parsing to not allow space between sign and digits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5338005: Fix number parsing to not allow space between sign and digits. (Closed)

Created:
10 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Karl Klose

CC:
v8-dev

Visibility:
Public.

Description

Fix number parsing to not allow space between sign and digits. Affects both parseFloat and ToNumber conversion. Fix issue 946.

Patch Set 2 : Address review comment. #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	src/conversions.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
	M	test/cctest/test-conversions.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

http://codereview.chromium.org/5338005/diff/1/src/conversions.cc File src/conversions.cc (right): http://codereview.chromium.org/5338005/diff/1/src/conversions.cc#newcode453 src/conversions.cc:453: if (current == end) return JUNK_STRING_VALUE; Should the comment ...

10 years ago (2010-11-26 12:40:12 UTC) #3

Lasse Reichstein

10 years ago (2010-11-26 12:46:01 UTC) #4

Good, LGTM.

Expand Messages | Collapse Messages

Issue 5338005: Fix number parsing to not allow space between sign and digits. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comment. #

Messages