Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 5338002: [cros] Use WideButton for all screens, increase textfield vmargin on login screen. (Closed)

Created:
10 years, 1 month ago by Nikita (slow)
Modified:
9 years, 7 months ago
Reviewers:
altimofeev
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[cros] Use WideButton for all screens, increase textfield vmargin on login screen. BUG=chromium-os:8101 TEST=Manual. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67123

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : moved ctor empty body to cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M chrome/browser/chromeos/login/eula_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/helper.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/network_selection_view.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/textfield_with_margin.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/textfield_with_margin.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M views/controls/button/text_button.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nikita (slow)
10 years, 1 month ago (2010-11-23 14:48:45 UTC) #1
altimofeev
10 years, 1 month ago (2010-11-23 15:24:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698