make DateParser::TimeComposer handle milliseconds properly...

test/mjsunit/regress/regress-944.js

Index: test/mjsunit/regress/regress-944.js
===================================================================
--- test/mjsunit/regress/regress-944.js	(revision 0)
+++ test/mjsunit/regress/regress-944.js	(revision 0)
@@ -0,0 +1,33 @@
+// Copyright 2010 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Redistributions of source code must retain the above copyright
+//       notice, this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above
+//       copyright notice, this list of conditions and the following
+//       disclaimer in the documentation and/or other materials provided
+//       with the distribution.
+//     * Neither the name of Google Inc. nor the names of its
+//       contributors may be used to endorse or promote products derived
+//       from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Checke for proper parsing of ES5 15.9.1.15 (ISO 8601 / RFC 3339) times

[Lasse Reichstein, 2010/11/25 10:17:19]

"Checke"->"Check".
Technically this is not ES5 15.9.1.15 parsing, since that only specifies
three-digit milliseconds. Say that it's testing an extension, or generalization,
of the spec format.

+// with millisecond values that have only 1 or 2 digits.
+assertEquals(1290690150500, Date.parse("2010-11-25T22:02:30.5"));

[Lasse Reichstein, 2010/11/25 10:17:19]

Also check that we fail with zero digits (i.e. "2010-11-25T22:02:30." gives
NaN).

Also check with more than three digits (since the parser allows it). In
particular, check that
- we truncate values instead of rounding (.1005 gives .100, not .101).
- we accept any number of digits (no reason to be stingy), e.g.
"2010-11-25T22:02:30.99999999999999999999999999999999999999999999999999999999999999999999999999999999999999"
(or more :)

+assertEquals(1290690150520, Date.parse("2010-11-25T22:02:30.52"));
+assertEquals(1290690150521, Date.parse("2010-11-25T22:02:30.521"));
+assertEquals(false, Date.parse("2010-11-25T22:02:30.5") === Date.parse("2010-11-25T22:02:30.005"));

[Lasse Reichstein, 2010/11/25 10:17:19]

Use assertFalse(...) instead of assertEquals(false, ...) (or feel free to add
assertNotEquals to mjsunit.js).