Added a master switch to enable/disable gpu acceleration.

Added a master switch to enable/disable gpu acceleration.
BUG=61771
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67923

[alokp, 2010-11-23 22:43:42]

Sending out for review. If the approach looks fine I will add unit-tests.

A couple things to note:
- It may have been better to just tweak a few flags in the CommandLine object to
get the same result without needing to add a gpu_enabled_ flag. But I was not
sure if it would be thread-safe
- I do not think it matters here, but do you think set_gpu_enabled() should be
routed to a particular thread?

[alokp, 2010-11-29 17:37:10]

ping!

[apatrick, 2010-11-29 17:45:38]

http://codereview.chromium.org/5334003/diff/1/chrome/browser/gpu_process_host.cc
File chrome/browser/gpu_process_host.cc (right):

http://codereview.chromium.org/5334003/diff/1/chrome/browser/gpu_process_host...
chrome/browser/gpu_process_host.cc:365: bool GpuProcessHost::LaunchGpuProcess()
{
Does making this function return false when g_gpu_crash_count not work? It might
be that the renderer processes are not yet sufficiently robust that case but
long term that us the the plan and it would simplify this code.

[alokp, 2010-11-29 18:34:38]

http://codereview.chromium.org/5334003/diff/1/chrome/browser/gpu_process_host.cc
File chrome/browser/gpu_process_host.cc (right):

http://codereview.chromium.org/5334003/diff/1/chrome/browser/gpu_process_host...
chrome/browser/gpu_process_host.cc:365: bool GpuProcessHost::LaunchGpuProcess()
{
On 2010/11/29 17:45:38, apatrick wrote:
> Does making this function return false when g_gpu_crash_count not work?

yes it works and I do that too via CanLaunchGpuProcess(). Two things going on
here:
1. I am disabling gpu acceleration for all new renderer processes through a
gpu_enabled flag in RenderViewHostDelegateHelper. The command-line passed to the
new renderer process instructs it to NOT use gpu-acceleration.
2. The exisiting tabs that have crashed will try to re-launch the gpu process.
CanLaunchGpuProcess() prevents those tabs from launch the gpu-process if it is
too crashy. Now the code to relaunch the gpu process is not ready, so I am not
sure if there is a better way.

[apatrick_chromium, 2010-11-29 20:59:31]

This seems fine for now at least. Just checking you aren't doing work you don't
need to :)

LGTM

http://codereview.chromium.org/5334003/diff/1/chrome/browser/gpu_process_host.cc
File chrome/browser/gpu_process_host.cc (right):

http://codereview.chromium.org/5334003/diff/1/chrome/browser/gpu_process_host...
chrome/browser/gpu_process_host.cc:54: // Maximaum number of times the gpu
process is allowed to crash in a session.
typo: Maximum

[alokp, 2010-11-29 21:25:52]

Vangelis?

[vangelis, 2010-11-30 22:19:36]

Looks good!