Issue 5333001: TestShell changes to support multiple speech input results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5333001: TestShell changes to support multiple speech input results. (Closed)

Created:
10 years, 1 month ago by Satish

Modified:
9 years, 7 months ago

Reviewers:
jorlow

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

TestShell changes to support multiple speech input results. This is the chromium side of https://bugs.webkit.org/show_bug.cgi?id=49736. BUG=none TEST=webkit layout tests will be enabled after this CL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67250

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -7 lines)			Patch
M	webkit/tools/test_shell/layout_test_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jorlow

This is a 2 sided patch. If you land this, you'll break chrome as is. ...

10 years, 1 month ago (2010-11-23 12:25:07 UTC) #1

Satish

10 years, 1 month ago (2010-11-23 12:50:14 UTC) #2

On 2010/11/23 12:25:07, jorlow wrote:
> This is a 2 sided patch.  If you land this, you'll break chrome as is.  You
need
> to land some transition step in the mean time (unless the roll happens soon,
in
> which case maybe you can just wait...?)

Makes sense. I see the canaries are red with test-shell break now, so I have
uploaded a new CL at http://codereview.chromium.org/5292002 as the transition
step for the webkit roll. Please take a look at that.

Expand Messages | Collapse Messages