Issue 5332004: Fix factory patching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5332004: Fix factory patching (Closed)

Created:
10 years, 1 month ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
Hung-Te

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Fix factory patching BUG=7535 TEST=build factory, no errors, verify patches. Change-Id: I480633cc7a0824cd2dfab82acd6a82f952cd7daf

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -21 lines)			Patch
	M	mod_for_factory_scripts/200patchInitScript	View		2 chunks	+4 lines, -20 lines	0 comments	Download
	M	mod_for_factory_scripts/factory_setup.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Hung-Te

Verified. LGTM, thanks for the quick fix. P.S: we may also need to add checking ...

10 years, 1 month ago (2010-11-24 05:44:07 UTC) #2

Nick Sanders

> P.S: we may also need to add checking of return value by the 'sed ...

10 years, 1 month ago (2010-11-24 06:04:08 UTC) #3

Hung-Te

10 years, 1 month ago (2010-11-24 06:20:16 UTC) #4

"grep -qs blah && sed -i command file" may be a simple solution