chromeos/compat-wireless/drivers/bluetooth/hci_ldisc.c - Issue 5326002: Update compat-wireless to 2.6.36-5-spn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/compat-wireless/drivers/bluetooth/hci_ldisc.c

Issue 5326002: Update compat-wireless to 2.6.36-5-spn (Closed) Base URL: http://git.chromium.org/git/kernel.git@master

Patch Set: Fixes for !ACK handling, missing local changes, log message fixes Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/compat-wireless/drivers/bluetooth/hci_ldisc.c

diff --git a/chromeos/compat-wireless/drivers/bluetooth/hci_ldisc.c b/chromeos/compat-wireless/drivers/bluetooth/hci_ldisc.c

index 41bec2112db7b0b03180621d40ac9eba08867b61..451eb24e6880b4c34a79a90ef6d21e8eb3c8bb53 100644

--- a/chromeos/compat-wireless/drivers/bluetooth/hci_ldisc.c

+++ b/chromeos/compat-wireless/drivers/bluetooth/hci_ldisc.c

@@ -256,9 +256,16 @@ static int hci_uart_tty_open(struct tty_struct *tty)

BT_DBG("tty %p", tty);

+ /* FIXME: This btw is bogus, nothing requires the old ldisc to clear

+ the pointer */

if (hu)

return -EEXIST;

+ /* Error if the tty has no write op instead of leaving an exploitable

+ hole */

+ if (tty->ops->write == NULL)

+ return -EOPNOTSUPP;

if (!(hu = kzalloc(sizeof(struct hci_uart), GFP_KERNEL))) {

BT_ERR("Can't allocate control structure");

return -ENFILE;