Simplify ProfLazyMode test on Linux.

Simplify ProfLazyMode test on Linux.

Instead of installing signal handler, count samples taken.

Committed: http://code.google.com/p/v8/source/detail?r=5891

[Vitaly Repeshko, 2010-11-25 15:01:20]

http://codereview.chromium.org/5325003/diff/1/src/platform.h
File src/platform.h (right):

http://codereview.chromium.org/5325003/diff/1/src/platform.h#newcode583
src/platform.h:583: unsigned int samples_taken() { return samples_taken_; }
Please document what this counter means and that it's exposed mainly for testing
purposes.

Style nit: the mutator functions names should be CamelCase.

http://codereview.chromium.org/5325003/diff/1/src/platform.h#newcode584
src/platform.h:584: void inc_samples_taken() { ++samples_taken_; }
Do we have to expose increment? Can't we do this before calling the
subclass-provided SampleStack? (E.g. we could have non-virtual SampleStack doing
increment and delegating the real work to virtual DoSampleStack.)

Another idea is to move this counter together with related functions to Ticker
and Logger.

http://codereview.chromium.org/5325003/diff/1/src/platform.h#newcode595
src/platform.h:595: unsigned int samples_taken_;
Unsigned is banned by the style guide
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Intege...).
If you really care about extra bits use int64_t.

http://codereview.chromium.org/5325003/diff/1/test/cctest/test-log.cc
File test/cctest/test-log.cc (right):

http://codereview.chromium.org/5325003/diff/1/test/cctest/test-log.cc#newcode257
test/cctest/test-log.cc:257: LoggerTestHelper::reset_samples_taken();
Should be done while the profiler is paused.

[mnaganov (inactive), 2010-11-25 15:26:56]

http://codereview.chromium.org/5325003/diff/1/src/platform.h
File src/platform.h (right):

http://codereview.chromium.org/5325003/diff/1/src/platform.h#newcode583
src/platform.h:583: unsigned int samples_taken() { return samples_taken_; }
On 2010/11/25 15:01:20, Vitaly wrote:
> Please document what this counter means and that it's exposed mainly for
testing
> purposes.
> 
> Style nit: the mutator functions names should be CamelCase.

Done.

http://codereview.chromium.org/5325003/diff/1/src/platform.h#newcode584
src/platform.h:584: void inc_samples_taken() { ++samples_taken_; }
On 2010/11/25 15:01:20, Vitaly wrote:
> Do we have to expose increment? Can't we do this before calling the
> subclass-provided SampleStack? (E.g. we could have non-virtual SampleStack
doing
> increment and delegating the real work to virtual DoSampleStack.)
> 
> Another idea is to move this counter together with related functions to Ticker
> and Logger.

Ticker is a module-private class, it can't be used outside of Logger. And I
don't like the idea of moving this counter to Logger, it's already too big.

I've made a non-virtual function that call IncSampleStack.

http://codereview.chromium.org/5325003/diff/1/src/platform.h#newcode595
src/platform.h:595: unsigned int samples_taken_;
On 2010/11/25 15:01:20, Vitaly wrote:
> Unsigned is banned by the style guide
>
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Intege...).
> If you really care about extra bits use int64_t.

I care about the possibility of having negative values. Fixed.

http://codereview.chromium.org/5325003/diff/1/test/cctest/test-log.cc
File test/cctest/test-log.cc (right):

http://codereview.chromium.org/5325003/diff/1/test/cctest/test-log.cc#newcode257
test/cctest/test-log.cc:257: LoggerTestHelper::reset_samples_taken();
On 2010/11/25 15:01:20, Vitaly wrote:
> Should be done while the profiler is paused.

Done.

[Vitaly Repeshko, 2010-11-25 15:48:45]

LGTM

http://codereview.chromium.org/5325003/diff/7001/src/platform.h
File src/platform.h (right):

http://codereview.chromium.org/5325003/diff/7001/src/platform.h#newcode602
src/platform.h:602: int samples_taken_;  // Counts stack samples taken. Used in
tests.
Please put this comment before the getter and reset in the public section.

[mnaganov (inactive), 2010-11-25 15:53:22]

http://codereview.chromium.org/5325003/diff/7001/src/platform.h
File src/platform.h (right):

http://codereview.chromium.org/5325003/diff/7001/src/platform.h#newcode602
src/platform.h:602: int samples_taken_;  // Counts stack samples taken. Used in
tests.
On 2010/11/25 15:48:46, Vitaly wrote:
> Please put this comment before the getter and reset in the public section.

Done.

[mnaganov (inactive), 2010-11-25 15:53:22]

http://codereview.chromium.org/5325003/diff/7001/src/platform.h
File src/platform.h (right):

http://codereview.chromium.org/5325003/diff/7001/src/platform.h#newcode602
src/platform.h:602: int samples_taken_;  // Counts stack samples taken. Used in
tests.
On 2010/11/25 15:48:46, Vitaly wrote:
> Please put this comment before the getter and reset in the public section.

Done.