Adding tests to browser.py...

Adding tests to browser.py

1. testSharingProcess
2. testKillSharedProcess

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71488

[Nirnimesh, 2010-11-30 21:31:12]

http://codereview.chromium.org/5322012/diff/1/functional/browser.py
File functional/browser.py (right):

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode178
functional/browser.py:178: def testSharingProcess(self):
rename: testPopupSharesProcess

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode187
functional/browser.py:187: parent_id =
self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid']
s/parent_id/parent_pid/

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode188
functional/browser.py:188: popup_id =
self.GetBrowserInfo()['windows'][1]['tabs'][0]['renderer_pid']
s/popup_id/popup_pid/

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode192
functional/browser.py:192: def testKillSharedProcess(self):
rename: testKillPopupProcess

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode193
functional/browser.py:193: """Verify that killing a shared process kills all
renderers."""
Please elaborate

[sunandt, 2010-12-07 02:29:36]

Modified.

http://codereview.chromium.org/5322012/diff/1/functional/browser.py
File functional/browser.py (right):

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode178
functional/browser.py:178: def testSharingProcess(self):
On 2010/11/30 21:31:12, Nirnimesh wrote:
> rename: testPopupSharesProcess

Done.

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode187
functional/browser.py:187: parent_id =
self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid']
On 2010/11/30 21:31:12, Nirnimesh wrote:
> s/parent_id/parent_pid/

Done.

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode188
functional/browser.py:188: popup_id =
self.GetBrowserInfo()['windows'][1]['tabs'][0]['renderer_pid']
On 2010/11/30 21:31:12, Nirnimesh wrote:
> s/popup_id/popup_pid/

Done.

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode192
functional/browser.py:192: def testKillSharedProcess(self):
On 2010/11/30 21:31:12, Nirnimesh wrote:
> rename: testKillPopupProcess
We are killing a process which is shared by both the parent and popup processes.
So, I think this is better.

http://codereview.chromium.org/5322012/diff/1/functional/browser.py#newcode193
functional/browser.py:193: """Verify that killing a shared process kills all
renderers."""
On 2010/11/30 21:31:12, Nirnimesh wrote:
> Please elaborate

Done.

[Nirnimesh, 2010-12-10 04:57:10]

LGTM. I'll commit this tomorrow.

[Nirnimesh, 2010-12-10 21:01:55]

On 2010/12/10 04:57:10, Nirnimesh wrote:
> LGTM. I'll commit this tomorrow.

It's flaky (on my Mac). testKillSharedProcess fails half the time.

[sunandt, 2010-12-10 22:20:39]

On 2010/12/10 21:01:55, Nirnimesh wrote:
> On 2010/12/10 04:57:10, Nirnimesh wrote:
> > LGTM. I'll commit this tomorrow.
> 
> It's flaky (on my Mac). testKillSharedProcess fails half the time.

Can you put the stack trace please?

[Nirnimesh, 2010-12-10 22:45:54]

======================================================================
FAIL: browser.BrowserTest.testKillSharedProcess: "Verify that killing a shared
process kills all associated renderers."
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Volumes/1/chrome/cr-git/src/chrome/test/functional/browser.py", line
212, in testKillSharedProcess
    self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid'])
AssertionError: 40461 != 40463



It might be related to the KillRenderer fix Ken applied in
http://codereview.chromium.org/5755003/

[sunandt_google.com, 2010-12-11 01:25:19]

Ken, Let me know once you commit the method to kill the renderer process.

On Fri, Dec 10, 2010 at 2:45 PM, <nirnimesh@chromium.org> wrote:

>
> ======================================================================
> FAIL: browser.BrowserTest.testKillSharedProcess: "Verify that killing a
> shared
> process kills all associated renderers."
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>  File "/Volumes/1/chrome/cr-git/src/chrome/test/functional/browser.py",
> line
> 212, in testKillSharedProcess
>    self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid'])
> AssertionError: 40461 != 40463
>
>
>
> It might be related to the KillRenderer fix Ken applied in
> http://codereview.chromium.org/5755003/
>
>
> http://codereview.chromium.org/5322012/
>

[sunandt, 2011-01-05 18:52:56]

Ken, Did you get a chance to commit the new method to kill a renderer process?

[kkania, 2011-01-05 18:57:22]

On 2011/01/05 18:52:56, sunandt wrote:
> Ken, Did you get a chance to commit the new method to kill a renderer process?

yes, it has been committed. sorry for the delay

[sunandt, 2011-01-05 19:24:50]

Replaced Kill with KillRendererProcess.

[Nirnimesh, 2011-01-07 00:28:39]

On 2011/01/05 19:24:50, sunandt wrote:
> Replaced Kill with KillRendererProcess.

LGTM.

[kkania, 2011-01-08 02:03:20]

LGTM

[sunandt, 2011-01-13 01:47:56]

Modified the test testKillSharedProcess. Now I'm reloading both the windows once
the renderers are killed. They should share a process id and it should be
different. Please take a look at this test again.

Thanks.

[Nirnimesh, 2011-01-14 20:07:45]

LGTM still

[Ken Kania, 2011-01-14 20:09:14]

LGTM

On Fri, Jan 14, 2011 at 12:07 PM, <nirnimesh@chromium.org> wrote:

> LGTM still
>
>
> http://codereview.chromium.org/5322012/
>