Before starting translation reset cache in AutoFillManager. To call Reset() f...

chrome/browser/renderer_host/render_view_host.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_view_host.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 1985 matching lines @@
 }
 
 void RenderViewHost::PerformCustomContextMenuAction(unsigned action) {
   Send(new ViewMsg_CustomContextMenuAction(routing_id(), action));
 }
 
 void RenderViewHost::TranslatePage(int page_id,
                                    const std::string& translate_script,
                                    const std::string& source_lang,
                                    const std::string& target_lang) {
+  // Before start translation, reset cache in AutoFillManager first.

[James Hawkins, 2010/11/23 19:18:53]

Please expand this comment to explain why.

[honten.org, 2010/11/23 19:32:22]

I want to replace the comment as following, what do you think?

Unfortunately form control element names are not always unique enough.  If the
labels change as a result of translation, we should be tracking those changes
and updating the caches in AutoFillManater.  Ideally we'd have a better way to
uniquely identify form control elements, but we don't have that yet.  So before
start translation, we clear the current form and re-parse it in AutoFillManter
first to get the new labels.
On 2010/11/23 19:18:53, James Hawkins wrote:

[James Hawkins, 2010/11/23 19:35:34]

Way too verbose. The last two sentences suffice.

+  RenderViewHostDelegate::AutoFill* autofill_delegate =
+    delegate_->GetAutoFillDelegate();
+  if (autofill_delegate)
+    autofill_delegate->Reset();
+
   Send(new ViewMsg_TranslatePage(routing_id(), page_id, translate_script,
                                  source_lang, target_lang));
 }
 
 void RenderViewHost::RevertTranslation(int page_id) {
   Send(new ViewMsg_RevertTranslation(routing_id(), page_id));
 }
 
 void RenderViewHost::SendContentSettings(const GURL& url,
                                          const ContentSettings& settings) {
@@ skipping 228 matching lines @@
   TabContents* print_preview_tab = GetOrCreatePrintPreviewTab();
   DCHECK(print_preview_tab);
 
   // TODO(kmadhusu): Function definition needs to be changed.
   // fd_in_browser should be the file descriptor of the metafile.
 
   // Send the printingDone msg for now.
   Send(new ViewMsg_PrintingDone(routing_id(), -1, true));
 }
 #endif