Issue 5321012: A quick fix for Bug 64463....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5321012: A quick fix for Bug 64463.... (Closed)

Created:
10 years ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
sanjeevr, willchan no longer on Chromium

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for Bug 64463. It seems scoped_refptr<MessageLoopProxy>::~scoped_refptr() cannot call MessageLoopProxyImpl::~MessageLoopProxyImpl() because it is not a virtual destructor. This change just changes it to a virtual one. BUG=64463 TEST=make the valgrind bots green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67976

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	base/message_loop_proxy_impl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/valgrind/memcheck/suppressions_mac.txt	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages