src/service.h - Issue 5321001: cashew: don't propagate inactive plans to clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/service.h

Issue 5321001: cashew: don't propagate inactive plans to clients (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/cashew.git@master

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/service.h

diff --git a/src/service.h b/src/service.h

index 442ea7119b4d59a90394af61e900791a9a24a6a7..dcbeb9fd5561f44e4d9c9724bb9d507770b03daa 100644

--- a/src/service.h

+++ b/src/service.h

@@ -78,6 +78,7 @@ class Service : public org::chromium::flimflam::Service_proxy,

virtual Device* GetDevice() const;

// get data plan info, formatted for D-Bus

+ // filters out inactive (future, expired, or consumed) plans

virtual DBusDataPlanList GetDBusDataPlans() const;

rtc 2010/11/23 04:38:58 Same comment about the accessor style. I'm happy w

Vince Laviano 2010/11/23 05:11:04 Done. Added TODO.

// do we think that we're the default service at this time?