cashew: don't propagate inactive plans to clients

src/service.h

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SRC_SERVICE_H_
 #define SRC_SERVICE_H_
 
 #include <glib.h>
 
 #include <map>
@@ skipping 60 matching lines @@
     virtual Type GetType() const;
 
     // convert type string to Type enum value
     static Type TypeFromString(const std::string& type);
 
     // get Device object for this service
     // this can return NULL if we don't yet have Device info
     virtual Device* GetDevice() const;
 
     // get data plan info, formatted for D-Bus
+    // filters out inactive (future, expired, or consumed) plans
     virtual DBusDataPlanList GetDBusDataPlans() const;

[rtc, 2010/11/23 04:38:58]

Same comment about the accessor style. I'm happy with TODOs in the headers for
now. 

[Vince Laviano, 2010/11/23 05:11:04]

Done. Added TODO.

 
     // do we think that we're the default service at this time?
     virtual bool IsDefaultService() const;
 
     typedef enum {
       kConnectivityStateUnknown = 0,
       kConnectivityStateRestricted,
       kConnectivityStateUnrestricted,
       kConnectivityStateNone,
     } ConnectivityState;
@@ skipping 204 matching lines @@
 
     // consult policy to determine if we should send an unsolicited update
     void MaybeEmitDataPlansUpdate();
 
     DISALLOW_COPY_AND_ASSIGN(Service);
 };
 
 }  // namespace cashew
 
 #endif  // SRC_SERVICE_H_