cashew: don't propagate inactive plans to clients

cashew: don't propagate inactive plans to clients

Filter inactive (future, expired, consumed) plans when responding to
client D-Bus requests or emitting D-Bus signals.

BUG=chromium-os:9397
TEST=unit tests, manual testing on device

Change-Id: Ie221823627b3864802100aa619aa04b8cb949ac7

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4c69558

[Vince Laviano, 2010-11-23 04:03:40]

The carrier usage API sometimes includes expired or fully consumed plans in the
plans list that it returns to cashew. Chrome unconditionally displays info about
the first plan in the list, assuming that it is the currently active plan. 

This CL modifies cashew to filter out inactive plans so that Chrome can be
assured of receiving an active plan in the first list position.

[rtc, 2010-11-23 04:38:58]

http://codereview.chromium.org/5321001/diff/1/src/data_plan.cc
File src/data_plan.cc (right):

http://codereview.chromium.org/5321001/diff/1/src/data_plan.cc#newcode54
src/data_plan.cc:54: CHECK_GE(data_bytes_used_, 0);
I'm wondering if it would be better to have unit test cases to replace these
asserts

http://codereview.chromium.org/5321001/diff/1/src/data_plan.h
File src/data_plan.h (right):

http://codereview.chromium.org/5321001/diff/1/src/data_plan.h#newcode82
src/data_plan.h:82: virtual Bytes GetTotalBytesUsed() const;
Google style says that accessors should not include "Get", just
total_bytes_used() instead of GetTotalBytesUsed()

http://codereview.chromium.org/5321001/diff/1/src/service.h
File src/service.h (left):

http://codereview.chromium.org/5321001/diff/1/src/service.h#oldcode81
src/service.h:81: virtual DBusDataPlanList GetDBusDataPlans() const;
Same comment about the accessor style. I'm happy with TODOs in the headers for
now.

[rtc, 2010-11-23 05:03:10]

LGTM, based on comments from IM.

-Ryan

On Mon, Nov 22, 2010 at 8:38 PM, <rtc@chromium.org> wrote:

>
> http://codereview.chromium.org/5321001/diff/1/src/data_plan.cc
> File src/data_plan.cc (right):
>
> http://codereview.chromium.org/5321001/diff/1/src/data_plan.cc#newcode54
> src/data_plan.cc:54: CHECK_GE(data_bytes_used_, 0);
> I'm wondering if it would be better to have unit test cases to replace
> these asserts
>
> http://codereview.chromium.org/5321001/diff/1/src/data_plan.h
> File src/data_plan.h (right):
>
> http://codereview.chromium.org/5321001/diff/1/src/data_plan.h#newcode82
> src/data_plan.h:82: virtual Bytes GetTotalBytesUsed() const;
> Google style says that accessors should not include "Get", just
> total_bytes_used() instead of GetTotalBytesUsed()
>
> http://codereview.chromium.org/5321001/diff/1/src/service.h
> File src/service.h (left):
>
> http://codereview.chromium.org/5321001/diff/1/src/service.h#oldcode81
> src/service.h:81: virtual DBusDataPlanList GetDBusDataPlans() const;
> Same comment about the accessor style. I'm happy with TODOs in the
> headers for now.
>
>
> http://codereview.chromium.org/5321001/
>

[Vince Laviano, 2010-11-23 05:11:04]

http://codereview.chromium.org/5321001/diff/1/src/data_plan.cc
File src/data_plan.cc (right):

http://codereview.chromium.org/5321001/diff/1/src/data_plan.cc#newcode54
src/data_plan.cc:54: CHECK_GE(data_bytes_used_, 0);
On 2010/11/23 04:38:58, rtc wrote:
> I'm wondering if it would be better to have unit test cases to replace these
> asserts

Removed asserts that test values hardcoded in member initialization list
(local_bytes_used) or that are defined in the member initialization list as
equivalent to other values that are already checked (total_bytes_used). 

The constraint that these values be >= 0 is checked by our unit tests.

http://codereview.chromium.org/5321001/diff/1/src/data_plan.h
File src/data_plan.h (right):

http://codereview.chromium.org/5321001/diff/1/src/data_plan.h#newcode82
src/data_plan.h:82: virtual Bytes GetTotalBytesUsed() const;
On 2010/11/23 04:38:58, rtc wrote:
> Google style says that accessors should not include "Get", just
> total_bytes_used() instead of GetTotalBytesUsed()

Added TODO.

http://codereview.chromium.org/5321001/diff/1/src/service.h
File src/service.h (left):

http://codereview.chromium.org/5321001/diff/1/src/service.h#oldcode81
src/service.h:81: virtual DBusDataPlanList GetDBusDataPlans() const;
On 2010/11/23 04:38:58, rtc wrote:
> Same comment about the accessor style. I'm happy with TODOs in the headers for
> now. 

Done. Added TODO.