Disable printing context menus on the print preview page.

Disable printing context menus on the print preview page.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68228

[Lei Zhang, 2010-12-02 04:09:52]

jam: Please take a look at the tab_contents.cc changes
kmadhusu: Please take a look at the print preview controller change.

[Paweł Hajdan Jr., 2010-12-02 09:36:36]

Drive-by with a test comment. Please do not commit without my explicit "LGTM".

http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print...
File chrome/browser/dom_ui/print_preview_ui_uitest.cc (right):

http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print...
chrome/browser/dom_ui/print_preview_ui_uitest.cc:69:
PlatformThread::Sleep(1000);
This is a no-go. Do you need to wait for some event?

[Lei Zhang, 2010-12-02 18:06:12]

http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print...
File chrome/browser/dom_ui/print_preview_ui_uitest.cc (right):

http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print...
chrome/browser/dom_ui/print_preview_ui_uitest.cc:69:
PlatformThread::Sleep(1000);
On 2010/12/02 09:36:36, Paweł Hajdan Jr. wrote:
> This is a no-go. Do you need to wait for some event?

I'm already waiting with WaitUntilTabCount() - I see the tab coming up, but for
some reason the TabProxy doesn't return the title properly. I can try
BrowserProxy::WaitUntilTabCount() and see if that makes a difference.

[kmadhusu, 2010-12-02 18:34:45]

On 2010/12/02 18:06:12, Lei Zhang wrote:
>
http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print...
> File chrome/browser/dom_ui/print_preview_ui_uitest.cc (right):
> 
>http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print_preview_ui_uitest.cc#newcode69
> chrome/browser/dom_ui/print_preview_ui_uitest.cc:69:
> PlatformThread::Sleep(1000);
> On 2010/12/02 09:36:36, Paweł Hajdan Jr. wrote:
> > This is a no-go. Do you need to wait for some event?
> 
> I'm already waiting with WaitUntilTabCount() - I see the tab coming up, but
for
> some reason the TabProxy doesn't return the title properly. I can try
> BrowserProxy::WaitUntilTabCount() and see if that makes a difference.

LGTM for print preview tab controller changes.

[Paweł Hajdan Jr., 2010-12-02 18:43:32]

http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print...
File chrome/browser/dom_ui/print_preview_ui_uitest.cc (right):

http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print...
chrome/browser/dom_ui/print_preview_ui_uitest.cc:69:
PlatformThread::Sleep(1000);
On 2010/12/02 18:06:12, Lei Zhang wrote:
> On 2010/12/02 09:36:36, Paweł Hajdan Jr. wrote:
> > This is a no-go. Do you need to wait for some event?
> 
> I'm already waiting with WaitUntilTabCount() - I see the tab coming up, but
for
> some reason the TabProxy doesn't return the title properly. I can try
> BrowserProxy::WaitUntilTabCount() and see if that makes a difference.

I think the main problem is that the test doesn't wait for the load to finish in
the second tab.

[jam, 2010-12-02 21:57:38]

tab_contents change lgtm.  the pdf isn't shown full-page right?  since if it is,
it will muck with the content_restrictions later

[Lei Zhang, 2010-12-02 22:06:19]

On 2010/12/02 21:57:38, John Abd-El-Malek wrote:
> tab_contents change lgtm.  the pdf isn't shown full-page right?  since if it
is,
> it will muck with the content_restrictions later

It's not full page. It's an <object>.

[Lei Zhang, 2010-12-03 00:19:09]

On 2010/12/02 09:36:36, Paweł Hajdan Jr. wrote:
> Drive-by with a test comment. Please do not commit without my explicit "LGTM".
> 
>
http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print...
> File chrome/browser/dom_ui/print_preview_ui_uitest.cc (right):
> 
>
http://codereview.chromium.org/5320001/diff/12001/chrome/browser/dom_ui/print...
> chrome/browser/dom_ui/print_preview_ui_uitest.cc:69:
> PlatformThread::Sleep(1000);
> This is a no-go. Do you need to wait for some event?

See patch set 3.

[Paweł Hajdan Jr., 2010-12-03 18:13:13]

LGTM. Thanks!