Also register read cookies in the content settings delegate.

net/url_request/url_request_http_job.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
@@ skipping 422 matching lines @@
 }
 
 void URLRequestHttpJob::StopCaching() {
   if (transaction_.get())
     transaction_->StopCaching();
 }
 
 void URLRequestHttpJob::OnCanGetCookiesCompleted(int policy) {
   // If the request was destroyed, then there is no more work to do.
   if (request_ && request_->delegate()) {
-    if (policy == net::ERR_ACCESS_DENIED) {
-      request_->delegate()->OnGetCookies(request_, true);
+    if (policy == net::ERR_ACCESS_DENIED &&
+        request_->context()->cookie_store()) {
+      request_->delegate()->OnGetCookies(
+          request_,
+          request_->context()->cookie_store()->GetCookieMonster()->

[darin (slow to review), 2010/11/24 18:10:47]

this is breaking the abstraction of the CookieStore interface.  there may not be
a CookieMonster behind it.

i'm concerned about the impact this will have on ChromeFrame, which uses a
CookieStore implemented on top of the host browser's network stack.

[jochen (gone - plz use gerrit), 2010/11/24 18:45:38]

Since the cookies aren't collected for chrome frame, I could only pass the url
and the request. Then the resource dispatcher host can check whether the context
is not external and grab the cookie monster to get the cookies.

wdyt

+              GetAllCookiesForURL(request_->url()),
+          true);
     } else if (policy == net::OK && request_->context()->cookie_store()) {
-      request_->delegate()->OnGetCookies(request_, false);
+      request_->delegate()->OnGetCookies(
+          request_,
+          request_->context()->cookie_store()->GetCookieMonster()->
+              GetAllCookiesForURL(request_->url()),
+          false);
       net::CookieOptions options;
       options.set_include_httponly();
       std::string cookies =
           request_->context()->cookie_store()->GetCookiesWithOptions(
               request_->url(), options);
       if (!cookies.empty()) {
         request_info_.extra_headers.SetHeader(
             net::HttpRequestHeaders::kCookie, cookies);
       }
     }
@@ skipping 459 matching lines @@
     HTTPSProberDelegate* delegate =
         new HTTPSProberDelegate(request_info_.url.host(), max_age,
                                 include_subdomains,
                                 ctx->transport_security_state());
     if (!prober->ProbeHost(request_info_.url.host(), request()->context(),
                            delegate)) {
       delete delegate;
     }
   }
 }