Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Side by Side Diff: chrome/browser/dom_ui/options/about_page_handler.cc

Issue 5315006: chromeos: Fix DOMUI about:credits link. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/dom_ui/options/about_page_handler.h" 5 #include "chrome/browser/dom_ui/options/about_page_handler.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 "license_link_0" : "license_link_1", 189 "license_link_0" : "license_link_1",
190 l10n_util::GetStringUTF16(IDS_CHROMIUM_PROJECT_URL)); 190 l10n_util::GetStringUTF16(IDS_CHROMIUM_PROJECT_URL));
191 191
192 // The Open Source link within the main text of the dialog. 192 // The Open Source link within the main text of the dialog.
193 localized_strings->SetString(chromium_url_appears_first ? 193 localized_strings->SetString(chromium_url_appears_first ?
194 "license_link_content_1" : "license_link_content_0", 194 "license_link_content_1" : "license_link_content_0",
195 WideToUTF16Hack(StringSubRange(text, 195 WideToUTF16Hack(StringSubRange(text,
196 text.find(kBeginLinkOss) + wcslen(kBeginLinkOss), 196 text.find(kBeginLinkOss) + wcslen(kBeginLinkOss),
197 text.find(kEndLinkOss)))); 197 text.find(kEndLinkOss))));
198 localized_strings->SetString(chromium_url_appears_first ? 198 localized_strings->SetString(chromium_url_appears_first ?
199 "license_link_1" : "license_link_0", chrome::kAboutCreditsURL); 199 "license_link_1" : "license_link_0", chrome::kChromeUIAboutCreditsURL);
200 200
201 // webkit 201 // webkit
202 202
203 localized_strings->SetString("webkit_version", 203 localized_strings->SetString("webkit_version",
204 webkit_glue::GetWebKitVersion()); 204 webkit_glue::GetWebKitVersion());
205 205
206 // javascript 206 // javascript
207 207
208 #if defined(CHROME_V8) 208 #if defined(CHROME_V8)
209 localized_strings->SetString("js_engine", "V8"); 209 localized_strings->SetString("js_engine", "V8");
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 381
382 void AboutPageHandler::OnOSVersion(chromeos::VersionLoader::Handle handle, 382 void AboutPageHandler::OnOSVersion(chromeos::VersionLoader::Handle handle,
383 std::string version) { 383 std::string version) {
384 if (version.size()) { 384 if (version.size()) {
385 scoped_ptr<Value> version_string(Value::CreateStringValue(version)); 385 scoped_ptr<Value> version_string(Value::CreateStringValue(version));
386 dom_ui_->CallJavascriptFunction(L"AboutPage.updateOSVersionCallback", 386 dom_ui_->CallJavascriptFunction(L"AboutPage.updateOSVersionCallback",
387 *version_string); 387 *version_string);
388 } 388 }
389 } 389 }
390 #endif 390 #endif
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/options/about_page.html » ('j') | chrome/common/url_constants.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698