chromeos: Fix DOMUI about:credits link.

chromeos: Fix DOMUI about:credits link.

The renderer doesn't let us link to about:credits, so make
the DOMUI settings page link to chrome://about/credits
instead (and initialize the about handler's data source when
the settings page is opened).  Also open these links in new
tabs instead of in the current one.

BUG=chromium-os:6728
TEST=built for chrome os and linux and checked that credits links work in both cases

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70246

[Daniel Erat, 2010-11-24 23:39:44]

chrome://about/credits worked after all.  When I tried it earlier, I think I
just edited the link via the dev tools; perhaps I did something wrong.

http://codereview.chromium.org/5315006/diff/1/chrome/common/url_constants.h
File chrome/common/url_constants.h (right):

http://codereview.chromium.org/5315006/diff/1/chrome/common/url_constants.h#n...
chrome/common/url_constants.h:63: // components below.
I ignored this comment, since there already seems to be little correspondence
between these constants and the kChromeUI*Host ones below. :-(  (There's no
entry down there for kChromeUIAboutURL, for instance.)

[tony, 2010-11-24 23:52:03]

LGTM.

I was originally confused because I couldn't find this page in linux chromium,
but derat showed me the page in a chromeos build.

[Daniel Erat, 2010-11-25 01:51:53]

Ugh.  So the reason it wasn't working seems to be that
chrome://about/credits is unloadable until about:credits has been
loaded at least once. :-(

On Wed, Nov 24, 2010 at 3:52 PM,  <tony@chromium.org> wrote:
> LGTM.
>
> I was originally confused because I couldn't find this page in linux
> chromium,
> but derat showed me the page in a chromeos build.
>
> http://codereview.chromium.org/5315006/
>

[Daniel Erat, 2010-12-28 22:11:50]

Okay, it looks like this works with the existing about handler as long as I both
link to chrome://about/credits (instead of about:credits) and initialize the
data source when we show the options page -- I'd tried them individually but not
together.

http://codereview.chromium.org/5315006/diff/10001/chrome/browser/dom_ui/optio...
File chrome/browser/dom_ui/options/options_ui.cc (right):

http://codereview.chromium.org/5315006/diff/10001/chrome/browser/dom_ui/optio...
chrome/browser/dom_ui/options/options_ui.cc:218:
WillHandleBrowserAboutURL(&about_credits_url, GetProfile());
This is ugly, but it looks like it's the only path for constructing the
singleton AboutSource object, which registers itself as a data source in its
constructor.

[arv (Not doing code reviews), 2010-12-28 22:28:08]

http://codereview.chromium.org/5315006/diff/10001/chrome/browser/dom_ui/optio...
File chrome/browser/dom_ui/options/options_ui.cc (right):

http://codereview.chromium.org/5315006/diff/10001/chrome/browser/dom_ui/optio...
chrome/browser/dom_ui/options/options_ui.cc:218:
WillHandleBrowserAboutURL(&about_credits_url, GetProfile());
On 2010/12/28 22:11:50, Daniel Erat wrote:
> This is ugly, but it looks like it's the only path for constructing the
> singleton AboutSource object, which registers itself as a data source in its
> constructor.

Another slightly cleaner solution would be to extract the AboutSource init code
from WillHandleBrowserAboutURL and call that. WillHandleBrowserAboutURL mostly
does URl rewrite which we do not care about here.

[Daniel Erat, 2010-12-28 22:39:23]

On 2010/12/28 22:28:08, arv wrote:
>
http://codereview.chromium.org/5315006/diff/10001/chrome/browser/dom_ui/optio...
> File chrome/browser/dom_ui/options/options_ui.cc (right):
> 
>
http://codereview.chromium.org/5315006/diff/10001/chrome/browser/dom_ui/optio...
> chrome/browser/dom_ui/options/options_ui.cc:218:
> WillHandleBrowserAboutURL(&about_credits_url, GetProfile());
> On 2010/12/28 22:11:50, Daniel Erat wrote:
> > This is ugly, but it looks like it's the only path for constructing the
> > singleton AboutSource object, which registers itself as a data source in its
> > constructor.
> 
> Another slightly cleaner solution would be to extract the AboutSource init
code
> from WillHandleBrowserAboutURL and call that. WillHandleBrowserAboutURL mostly
> does URl rewrite which we do not care about here.

Sure, thanks.  Another look?

[arv (Not doing code reviews), 2010-12-28 23:10:12]

LGTM