New Heap profiler: fix JSON serialization of aggregated profiles.

New Heap profiler: fix JSON serialization of aggregated profiles.

Serialization was failing due to unset dominator pointers.

TEST=test-heap-snapshot/AggregatedHeapSnapshotJSONSerialization

Committed: http://code.google.com/p/v8/source/detail?r=5888

[Vitaly Repeshko, 2010-11-23 15:27:40]

Drive by question.


-- Vitaly

http://codereview.chromium.org/5314003/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/5314003/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:877: dominator_ = NULL;
Can we set it to "this" here instead?

[mnaganov (inactive), 2010-11-23 15:30:38]

http://codereview.chromium.org/5314003/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/5314003/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:877: dominator_ = NULL;
On 2010/11/23 15:27:40, Vitaly wrote:
> Can we set it to "this" here instead?

No. The algorithm (see HeapSnapshot::BuildDominatorTree) is iterative and uses
NULL values to distinguish nodes for which the dominator hasn't been determined
yet.

[Søren Thygesen Gjesse, 2010-11-24 08:18:23]

LGTM