Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: media/base/filters.h

Issue 53126: Demuxer stream now uses a callback instead of Assignable template. Cleaning ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/mock_media_filters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filters.h
===================================================================
--- media/base/filters.h (revision 12628)
+++ media/base/filters.h (working copy)
@@ -29,6 +29,7 @@
#include "base/logging.h"
#include "base/ref_counted.h"
+#include "base/task.h"
#include "base/time.h"
#include "media/base/media_format.h"
@@ -156,8 +157,9 @@
// Returns the MediaFormat for this filter.
virtual const MediaFormat& media_format() = 0;
- // Schedules a read and takes ownership of the given buffer.
- virtual void Read(Assignable<Buffer>* buffer) = 0;
+ // Schedules a read. When the |read_callback| is called, the downstream
+ // filter takes ownership of the buffer by AddRef()'ing the buffer.
+ virtual void Read(Callback1<Buffer*>::Type* read_callback) = 0;
// Given a class that supports the |Interface| and a related static method
// interface_id(), which returns a const char*, this method returns true if
« no previous file with comments | « no previous file | media/base/mock_media_filters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698