Do not return an AXValue for buttons to match Safari....

Do not return an AXValue for buttons to match Safari.
BUG=n57345
TEST=manually with VoiceOver.	

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67941

[Chris Guillory, 2010-11-29 22:38:44]

Couple of comments. What's the new behavior with this change? I'm not
understanding what this will change and there isn't a referenced bug.

http://codereview.chromium.org/5310009/diff/1/chrome/browser/accessibility/br...
File chrome/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/5310009/diff/1/chrome/browser/accessibility/br...
chrome/browser/accessibility/browser_accessibility_cocoa.mm:213: // Webcore uses
an attachmentView to get the below behavior.
Nit: Capitalize the 'C' in WebCore (since the 'W' is capitalized).

http://codereview.chromium.org/5310009/diff/1/chrome/browser/accessibility/br...
chrome/browser/accessibility/browser_accessibility_cocoa.mm:229: // Does not
make sense for pure buttons.
What does not make sense for pure buttons? AXValue? Can we add that to the
comment?

[David Tseng, 2010-11-29 22:50:34]

On 11/29/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
> Couple of comments. What's the new behavior with this change? I'm not
> understanding what this will change and there isn't a referenced bug.

The bug is:
http://code.google.com/p/chromium/issues/detail?id=57345&can=3&q=accessibilit...
I'll add it to the patch.
>
>
http://codereview.chromium.org/5310009/diff/1/chrome/browser/accessibility/br...
> File chrome/browser/accessibility/browser_accessibility_cocoa.mm
> (right):
>
>
http://codereview.chromium.org/5310009/diff/1/chrome/browser/accessibility/br...
> chrome/browser/accessibility/browser_accessibility_cocoa.mm:213: //
> Webcore uses an attachmentView to get the below behavior.
> Nit: Capitalize the 'C' in WebCore (since the 'W' is capitalized).
>
Done.
>
http://codereview.chromium.org/5310009/diff/1/chrome/browser/accessibility/br...
> chrome/browser/accessibility/browser_accessibility_cocoa.mm:229: // Does
> not make sense for pure buttons.
> What does not make sense for pure buttons? AXValue? Can we add that to
> the comment?
>
Done.
> http://codereview.chromium.org/5310009/
>

[David Tseng, 2010-12-01 22:06:47]

Hey Chris, I added more comments to the bug earlier; does this patch
look good with the clarifications in the bug?

On 11/29/10, David Tseng <dtseng@chromium.org> wrote:
> On 11/29/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
>> Couple of comments. What's the new behavior with this change? I'm not
>> understanding what this will change and there isn't a referenced bug.
>
> The bug is:
>
http://code.google.com/p/chromium/issues/detail?id=57345&can=3&q=accessibilit...
> I'll add it to the patch.
>>
>>
http://codereview.chromium.org/5310009/diff/1/chrome/browser/accessibility/br...
>> File chrome/browser/accessibility/browser_accessibility_cocoa.mm
>> (right):
>>
>>
http://codereview.chromium.org/5310009/diff/1/chrome/browser/accessibility/br...
>> chrome/browser/accessibility/browser_accessibility_cocoa.mm:213: //
>> Webcore uses an attachmentView to get the below behavior.
>> Nit: Capitalize the 'C' in WebCore (since the 'W' is capitalized).
>>
> Done.
>>
http://codereview.chromium.org/5310009/diff/1/chrome/browser/accessibility/br...
>> chrome/browser/accessibility/browser_accessibility_cocoa.mm:229: // Does
>> not make sense for pure buttons.
>> What does not make sense for pure buttons? AXValue? Can we add that to
>> the comment?
>>
> Done.
>> http://codereview.chromium.org/5310009/
>>
>

[Chris Guillory, 2010-12-01 23:37:57]

LGTM.