Issue 5310001: Reconstructing 67000....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5310001: Reconstructing 67000.... (Closed)

Created:
10 years, 1 month ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
nsylvain

CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, amit, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Reconstructing 67000. (python24 -> python26). Regression in nacl fixed, new DEPS change. BUG=None TEST=NOne Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67057

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	DEPS	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	base/process_util_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ceee/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/chrome_frame_launcher.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/test/python_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/test/test_server_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nsylvain

10 years, 1 month ago (2010-11-24 01:46:01 UTC) #2

LGTM

On Mon, Nov 22, 2010 at 5:48 PM, <bradnelson@google.com> wrote:

> Reviewers: nsylvain,
>
> Description:
> Reconstructing 67000.
> (python24 -> python26).
>
> Regression in nacl fixed, new DEPS change.
>
> BUG=None
> TEST=NOne
>
>
>
> Please review this at http://codereview.chromium.org/5310001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>  M     base/process_util_unittest.cc
>  M     ceee/common.gypi
>  M     chrome/chrome_tests.gypi
>  M     chrome_frame/chrome_frame.gyp
>  M     chrome_frame/chrome_frame_launcher.gyp
>  M     net/test/python_utils.cc
>  M     net/test/test_server_win.cc
>
>
>

Expand Messages | Collapse Messages