Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Issue 53092: Fix window.history GC issue. Since the history object is not part of... (Closed)

Created:
11 years, 9 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix window.history GC issue. Since the history object is not part of the DOM, we need to explicitly keep the history wrapper object alive for the lifetime of the DOMWindow object with which it is associated. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12543

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M webkit/port/bindings/v8/v8_custom.h View 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/port/bindings/v8/v8_proxy.cpp View 1 2 chunks +23 lines, -12 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
First batch of GC changes. More objects need this treatment, but in order to do ...
11 years, 9 months ago (2009-03-26 12:17:48 UTC) #1
Søren Thygesen Gjesse
LGTM Do we have a GC test for this, or was the test fixed by ...
11 years, 9 months ago (2009-03-26 12:29:26 UTC) #2
Mads Ager (chromium)
11 years, 9 months ago (2009-03-26 12:32:32 UTC) #3
The test fixed by this failed consistently on Windows and not on Mac and Linux. 
When I do the full change, I will add a GC layout test for all the objects.

Powered by Google App Engine
This is Rietveld 408576698