Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 53076: Add support for -Duse_system_{libxml,libxslt,sqlite}=1 for... (Closed)

Created:
11 years, 9 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai, fta
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add support for -Duse_system_{libxml,libxslt,sqlite}=1 for selection of the system version of those libraries on Linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12521

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -360 lines) Patch
M third_party/libxml/libxml.gyp View 2 chunks +158 lines, -141 lines 0 comments Download
M third_party/libxslt/libxslt.gyp View 2 chunks +86 lines, -69 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 2 chunks +169 lines, -150 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
sgk
I verified that use of -Duse_system_*=1 causes the right pkg-config command to be run, but ...
11 years, 9 months ago (2009-03-25 23:17:31 UTC) #1
Mark Mentovai
LGTM. Nice. Real nice. http://codereview.chromium.org/53076/diff/1/4 File third_party/sqlite/sqlite.gyp (right): http://codereview.chromium.org/53076/diff/1/4#newcode197 Line 197: ['OS=="linux"', { and !use_system_sqlite
11 years, 9 months ago (2009-03-25 23:29:03 UTC) #2
sgk
11 years, 9 months ago (2009-03-25 23:44:21 UTC) #3
http://codereview.chromium.org/53076/diff/1/4
File third_party/sqlite/sqlite.gyp (right):

http://codereview.chromium.org/53076/diff/1/4#newcode197
Line 197: ['OS=="linux"', {
On 2009/03/25 23:29:03, Mark Mentovai wrote:
> and !use_system_sqlite

?  I don't think so.  Seems like you should be able to build sqlite_shell
against either the system or hermetic versions of the sqlite library.

Powered by Google App Engine
This is Rietveld 408576698