Issue 53074: Make sure filters can handle an empty input buffer...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53074: Make sure filters can handle an empty input buffer... (Closed)

Created:
11 years, 9 months ago by jar (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make sure filters can handle an empty input buffer The chaining of filters helped to guarantee that buffers were properly flushed when large expansions took place. That change assumed that a filter could be called with no input (as some filters need to be called repeatedly this way to purge massive internal state). The gzip and bzip filters were returning an error in that scenario. bug=9316 r=huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12524

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	net/base/bzip2_filter.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	net/base/gzip_filter.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm. would be nice to have test for this.

Expand Messages | Collapse Messages