GTK: Drags of images should have titles instead of "".

GTK: Drags of images should have titles instead of "".

BUG=32132
TEST=Drag an image from the content area to the bookmark bar. It should have a title.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67761

[Evan Stade, 2010-11-30 21:28:20]

LGTM

http://codereview.chromium.org/5307005/diff/1/app/gtk_dnd_util.cc
File app/gtk_dnd_util.cc (right):

http://codereview.chromium.org/5307005/diff/1/app/gtk_dnd_util.cc#newcode152
app/gtk_dnd_util.cc:152: // Can't have an empty title. Set it to the filename
extracted from the
nit: "Can't"? Isn't it more like "Prefer to avoid"

[sky, 2010-11-30 22:14:08]

http://codereview.chromium.org/5307005/diff/1/app/gtk_dnd_util.cc
File app/gtk_dnd_util.cc (right):

http://codereview.chromium.org/5307005/diff/1/app/gtk_dnd_util.cc#newcode154
app/gtk_dnd_util.cc:154: title = UTF8ToUTF16(url.ExtractFileName());
Might the filename be empty too?

[Elliot Glaysher, 2010-11-30 22:18:20]

http://codereview.chromium.org/5307005/diff/1/app/gtk_dnd_util.cc
File app/gtk_dnd_util.cc (right):

http://codereview.chromium.org/5307005/diff/1/app/gtk_dnd_util.cc#newcode154
app/gtk_dnd_util.cc:154: title = UTF8ToUTF16(url.ExtractFileName());
On 2010/11/30 22:14:08, sky wrote:
> Might the filename be empty too?

I'm not really concerned about that. In that case, we have the same behaviour as
before (it's not as if we segfault on empty titles, we just create suboptimal
bookmarks). In the case where the title is empty, there isn't an exposed string
for us to grab on to.

[sky, 2010-11-30 22:21:47]

Fair enough. LGTM