Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 53069: Add a copy of the V8 Benchmark Suite (version 3) for performance testing.... (Closed)

Created:
11 years, 9 months ago by Patrick Johnson
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a copy of the V8 Benchmark Suite (version 3) for performance testing. This copy was fetched from: http://v8.googlecode.com/svn/data/benchmarks/v3 This copy is unmodified from its original source. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12525

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13428 lines, -0 lines) Patch
A chrome/test/data/v8_benchmark/README.chromium View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/README.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/base.js View 1 chunk +233 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/crypto.js View 1 chunk +1698 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/deltablue.js View 1 chunk +880 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/earley-boyer.js View 1 chunk +4685 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/raytrace.js View 1 chunk +3434 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/regexp.js View 1 chunk +1614 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/revisions.html View 1 chunk +62 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/richards.js View 1 chunk +539 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/run.html View 1 chunk +102 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/run.js View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/style.css View 1 chunk +70 lines, -0 lines 0 comments Download
A chrome/test/data/v8_benchmark/v8-logo.png View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
Patrick Johnson
Very similar to the SunSpider tests. First, check in a clean copy. Then add a ...
11 years, 9 months ago (2009-03-25 21:03:22 UTC) #1
Pam (message me for reviews)
One nit, then LGTM. (Mostly rubber-stamped.) - Pam http://codereview.chromium.org/53069/diff/30/31 File chrome/test/data/v8_benchmark/README.chromium (right): http://codereview.chromium.org/53069/diff/30/31#newcode6 Line 6: ...
11 years, 9 months ago (2009-03-25 21:46:13 UTC) #2
Patrick Johnson
11 years, 9 months ago (2009-03-25 21:54:39 UTC) #3
http://codereview.chromium.org/53069/diff/30/31
File chrome/test/data/v8_benchmark/README.chromium (right):

http://codereview.chromium.org/53069/diff/30/31#newcode6
Line 6: Version: 3
On 2009/03/25 21:46:13, Pam wrote:
> Add the URL from which it was downloaded?

Done.

Powered by Google App Engine
This is Rietveld 408576698