Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: chrome/browser/tab_contents/web_contents_view_gtk.cc

Issue 53065: Fix/punt on a bunch of NOTIMPLEMENTEDs. (Closed)
Patch Set: better setpagetitle Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_gtk.cc ('k') | chrome/common/chrome_plugin_lib.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/web_contents_view_gtk.cc
diff --git a/chrome/browser/tab_contents/web_contents_view_gtk.cc b/chrome/browser/tab_contents/web_contents_view_gtk.cc
index 3f4785f6dc25a249b2471ca41723a35c53e67b30..6e6577f4d534c7a2a0e5e6f9c84a2abe9376c73c 100644
--- a/chrome/browser/tab_contents/web_contents_view_gtk.cc
+++ b/chrome/browser/tab_contents/web_contents_view_gtk.cc
@@ -114,7 +114,12 @@ gfx::NativeWindow WebContentsViewGtk::GetTopLevelNativeWindow() const {
}
void WebContentsViewGtk::GetContainerBounds(gfx::Rect* out) const {
- NOTIMPLEMENTED();
+ // This is used for positioning the download shelf arrow animation,
+ // as well as sizing some other widgets in Windows. In GTK the size is
+ // managed for us, so it appears to be only used for the download shelf
+ // animation.
+ out->SetRect(vbox_.get()->allocation.x, vbox_.get()->allocation.y,
+ vbox_.get()->allocation.width, vbox_.get()->allocation.height);
}
void WebContentsViewGtk::OnContentsDestroy() {
@@ -123,7 +128,10 @@ void WebContentsViewGtk::OnContentsDestroy() {
}
void WebContentsViewGtk::SetPageTitle(const std::wstring& title) {
- NOTIMPLEMENTED();
+ // Set the window name to include the page title so it's easier to spot
+ // when debugging (e.g. via xwininfo -tree).
+ if (content_view_)
+ gdk_window_set_title(content_view_->window, WideToASCII(title).c_str());
}
void WebContentsViewGtk::Invalidate() {
@@ -168,7 +176,7 @@ void WebContentsViewGtk::RestoreFocus() {
// TODO(estade): implement this function.
// For now just assume we are viewing the tab for the first time.
SetInitialFocus();
- NOTIMPLEMENTED();
+ NOTIMPLEMENTED() << " -- need to restore the focus position on this page.";
}
void WebContentsViewGtk::UpdateDragCursor(bool is_drop_target) {
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_gtk.cc ('k') | chrome/common/chrome_plugin_lib.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698