Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: chrome/common/chrome_plugin_lib.cc

Issue 53065: Fix/punt on a bunch of NOTIMPLEMENTEDs. (Closed)
Patch Set: better setpagetitle Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_plugin_lib.h" 5 #include "chrome/common/chrome_plugin_lib.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/hash_tables.h" 8 #include "base/hash_tables.h"
9 #include "base/histogram.h" 9 #include "base/histogram.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 void ChromePluginLib::RegisterPluginsWithNPAPI() { 115 void ChromePluginLib::RegisterPluginsWithNPAPI() {
116 // We don't support ChromePlugins in single-process mode. 116 // We don't support ChromePlugins in single-process mode.
117 if (IsSingleProcessMode()) 117 if (IsSingleProcessMode())
118 return; 118 return;
119 119
120 FilePath path; 120 FilePath path;
121 if (!PathService::Get(chrome::FILE_GEARS_PLUGIN, &path)) 121 if (!PathService::Get(chrome::FILE_GEARS_PLUGIN, &path))
122 return; 122 return;
123 // Note: we can only access the NPAPI list because the PluginService has done 123 // Note: we can only access the NPAPI list because the PluginService has done
124 // the locking for us. We should not touch it anywhere else. 124 // the locking for us. We should not touch it anywhere else.
125 #if defined(OS_WIN) 125 #if defined(OS_WIN) || defined(OS_LINUX)
126 NPAPI::PluginList::AddExtraPluginPath(path); 126 NPAPI::PluginList::AddExtraPluginPath(path);
127 #else 127 #else
128 // TODO(port): plugins not yet implemented 128 // TODO(port): plugins not yet implemented
129 NOTIMPLEMENTED(); 129 NOTIMPLEMENTED();
130 #endif 130 #endif
131 } 131 }
132 132
133 static void LogPluginLoadTime(const TimeDelta &time) { 133 static void LogPluginLoadTime(const TimeDelta &time) {
134 UMA_HISTOGRAM_TIMES("Gears.LoadTime", time); 134 UMA_HISTOGRAM_TIMES("Gears.LoadTime", time);
135 } 135 }
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 int ChromePluginLib::CP_Test(void* param) { 248 int ChromePluginLib::CP_Test(void* param) {
249 DCHECK(initialized_); 249 DCHECK(initialized_);
250 if (!CP_Test_) 250 if (!CP_Test_)
251 return -1; 251 return -1;
252 return CP_Test_(param); 252 return CP_Test_(param);
253 } 253 }
254 254
255 bool ChromePluginLib::Load() { 255 bool ChromePluginLib::Load() {
256 #if !defined(OS_WIN) 256 #if !defined(OS_WIN)
257 // TODO(port): plugins not yet implemented 257 // TODO(port): plugins not yet implemented
258 NOTIMPLEMENTED(); 258 NOTIMPLEMENTED() << " -- gears loading code.";
259 return false; 259 return false;
260 #else 260 #else
261 DCHECK(module_ == 0); 261 DCHECK(module_ == 0);
262 #ifdef GEARS_STATIC_LIB 262 #ifdef GEARS_STATIC_LIB
263 FilePath path; 263 FilePath path;
264 if (filename_.BaseName().value().find(FILE_PATH_LITERAL("gears")) == 0) { 264 if (filename_.BaseName().value().find(FILE_PATH_LITERAL("gears")) == 0) {
265 CP_Initialize_ = &Gears_CP_Initialize; 265 CP_Initialize_ = &Gears_CP_Initialize;
266 return true; 266 return true;
267 } 267 }
268 #endif 268 #endif
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 if (initialized_) 302 if (initialized_)
303 CP_Shutdown(); 303 CP_Shutdown();
304 304
305 #if defined(OS_WIN) 305 #if defined(OS_WIN)
306 if (module_) { 306 if (module_) {
307 FreeLibrary(module_); 307 FreeLibrary(module_);
308 module_ = 0; 308 module_ = 0;
309 } 309 }
310 #endif 310 #endif
311 } 311 }
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/web_contents_view_gtk.cc ('k') | chrome/common/temp_scaffolding_stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698