Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 53057: src/platform-linux.cc in v8_base now seems to need '-lrt' for... (Closed)

Created:
11 years, 9 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

src/platform-linux.cc in v8_base now seems to need '-lrt' for clock_gettime(). Add it to link_settings, and add the right export_dependent_settings to propagate it through the hierarchy appropriately. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12468

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M build/temp_gyp/v8.gyp View 1 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sgk
11 years, 9 months ago (2009-03-25 17:13:59 UTC) #1
Mark Mentovai
http://codereview.chromium.org/53057/diff/1/2 File build/temp_gyp/v8.gyp (right): http://codereview.chromium.org/53057/diff/1/2#newcode340 Line 340: 'direct_dependent_settings': { should be link_settings
11 years, 9 months ago (2009-03-25 17:52:49 UTC) #2
sgk
11 years, 9 months ago (2009-03-25 17:57:14 UTC) #3
http://codereview.chromium.org/53057/diff/1/2
File build/temp_gyp/v8.gyp (right):

http://codereview.chromium.org/53057/diff/1/2#newcode340
Line 340: 'direct_dependent_settings': {
On 2009/03/25 17:52:49, Mark Mentovai wrote:
> should be link_settings

Done.

Powered by Google App Engine
This is Rietveld 408576698