Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6874)

Unified Diff: chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc

Issue 5305005: Initialize destinations variables before calling GL functions... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc
===================================================================
--- chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc (revision 67161)
+++ chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc (working copy)
@@ -693,7 +693,7 @@
scoped_array<GLchar> log(new GLchar[logLength]);
if (!log.get())
return WebKit::WebString();
- GLsizei returnedLogLength;
+ GLsizei returnedLogLength = 0;
glGetProgramInfoLog(program, logLength, &returnedLogLength, log.get());
DCHECK_EQ(logLength, returnedLogLength + 1);
WebKit::WebString res =
@@ -716,7 +716,7 @@
scoped_array<GLchar> log(new GLchar[logLength]);
if (!log.get())
return WebKit::WebString();
- GLsizei returnedLogLength;
+ GLsizei returnedLogLength = 0;
glGetShaderInfoLog(shader, logLength, &returnedLogLength, log.get());
DCHECK_EQ(logLength, returnedLogLength + 1);
WebKit::WebString res =
@@ -734,7 +734,7 @@
scoped_array<GLchar> log(new GLchar[logLength]);
if (!log.get())
return WebKit::WebString();
- GLsizei returnedLogLength;
+ GLsizei returnedLogLength = 0;
glGetShaderSource(shader, logLength, &returnedLogLength, log.get());
DCHECK_EQ(logLength, returnedLogLength + 1);
WebKit::WebString res =

Powered by Google App Engine
This is Rietveld 408576698