Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: src/frames-inl.h

Issue 53050: Add another check in profiler's stack iterator to ensure stability. (Closed)
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames-inl.h
diff --git a/src/frames-inl.h b/src/frames-inl.h
index 32820a5811f2c5134f5c0afc730ab79cdb990707..07c8e4ede55c7b9f39845f44aa4d50087cecf649 100644
--- a/src/frames-inl.h
+++ b/src/frames-inl.h
@@ -171,7 +171,13 @@ inline bool JavaScriptFrame::has_adapted_arguments() const {
inline bool JavaScriptFrame::is_at_function() const {
Object* result = function_slot_object();
+ // Verify that frame points at correct JS function object.
+ // We are verifying that function object address and
+ // the underlying map object address are valid, and that
+ // function is really a function.
return Heap::Contains(reinterpret_cast<Address>(result)) &&
+ result->IsHeapObject() &&
+ Heap::Contains(HeapObject::cast(result)->map()) &&
result->IsJSFunction();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698