Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 53050: Add another check in profiler's stack iterator to ensure stability. (Closed)

Created:
11 years, 9 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Add another check in profiler's stack iterator to ensure stability. I made a test run of benchmarks and found another weak point. After fixing it, benchmarks are able to run for a 100 times in a row successfully in both builds. Committed: http://code.google.com/p/v8/source/detail?r=1612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/frames-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mikhail Naganov
11 years, 9 months ago (2009-03-25 13:53:24 UTC) #1
Kasper Lund
LGTM as long as is_at_function() is only called from the safe iterator which I think ...
11 years, 9 months ago (2009-03-25 14:03:56 UTC) #2
Mikhail Naganov
11 years, 9 months ago (2009-03-25 14:07:12 UTC) #3
On 2009/03/25 14:03:56, Kasper Lund wrote:
> LGTM as long as is_at_function() is only called from the safe iterator which I
> think is the case.

Yes, you are right. It was added specifically for it.

Powered by Google App Engine
This is Rietveld 408576698