Add support for saving VM state after test failure

client/common_lib/test.py

 # Shell class for a test, inherited by all individual tests
 #
 # Methods:
 #       __init__        initialise
 #       initialize      run once for each job
 #       setup           run once for each new version of the test installed
 #       run             run the test (wrapped by job.run_test())
 #
 # Data:
 #       job             backreference to the job this test instance is part of
 #       outputdir       eg. results/<job>/<testname.tag>
 #       resultsdir      eg. results/<job>/<testname.tag>/results
 #       profdir         eg. results/<job>/<testname.tag>/profiling
 #       debugdir        eg. results/<job>/<testname.tag>/debug
 #       bindir          eg. tests/<test>
 #       src             eg. tests/<test>/src
 #       tmpdir          eg. tmp/<tempname>_<testname.tag>
 
 import fcntl, getpass, os, re, sys, shutil, tarfile, tempfile, time, traceback
 import warnings, logging, glob, resource
 
+from datetime import datetime
 from autotest_lib.client.common_lib import error
 from autotest_lib.client.bin import utils
 
 
 class base_test(object):
     preserve_srcdir = False
     network_destabilizing = False
 
     def __init__(self, job, bindir, outputdir):
         self.job = job
@@ skipping 379 matching lines @@
                     p_args, p_dargs = _cherry_pick_args(self.execute,
                                                         args, dargs)
 
                 _call_test_function(self.execute, *p_args, **p_dargs)
             except Exception:
                 try:
                     logging.exception('Exception escaping from test:')
                 except:
                     pass # don't let logging exceptions here interfere
 
+                # Save the VM state immediately after the test failure.
+                # This is a NOOP if the the test isn't running in a VM or
+                # if the VM is not properly configured to save state.
+                now = datetime.now().strftime('%I:%M:%S.%f')
+                checkpoint_name = "%s-%s" % (self.tagged_testname, now)

[sosa, 2010/11/24 01:02:54]

Don't mix "" and ''

[sosa, 2010/11/24 01:02:54]

It may be more useful to get something about the machine ... lsb-release entry
maybe like the version of chromeos?

[thieule, 2010/11/24 18:00:45]

Done.

[thieule, 2010/11/24 18:00:45]

The qcow2 file is tied to a particular base image.  The qcow2 file and
chromiumos_qemu_image.bin will be uploaded to a common Google Storage folder
that will contain the build information.  I was using the checkpoint name as a
way to identify the various VM states after a test failure.  The timestamp in
the checkpoint name can be used to correlate with the logs.  Also, some tests
are executed more than once in a suite and I needed a way to uniquely identify
each instance.

+                utils.save_vm_state(checkpoint_name)
+
                 # Save the exception while we run our cleanup() before
                 # reraising it.
                 exc_info = sys.exc_info()
                 try:
                     try:
                         if run_cleanup:
                             _cherry_pick_call(self.cleanup, *args, **dargs)
                     except Exception:
                         print 'Ignoring exception during cleanup() phase:'
                         traceback.print_exc()
@@ skipping 251 matching lines @@
         if before_iteration_hook:
             mytest.register_before_iteration_hook(before_iteration_hook)
         if after_iteration_hook:
             mytest.register_after_iteration_hook(after_iteration_hook)
         mytest._exec(args, dargs)
     finally:
         os.chdir(pwd)
         if after_test_hook:
             after_test_hook(mytest)
         shutil.rmtree(mytest.tmpdir, ignore_errors=True)