Issue 5303002: Add more exception information to breakpad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5303002: Add more exception information to breakpad. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add more exception information to breakpad. When an HTTP exception information is logged, no information is sent by default. Add an helper function to manually extract interesting information to append it to the exception type. Also disable another pylint warning. TEST=manual test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67306

Patch Set 1 #

Patch Set 2 : Add url too #

Patch Set 3 : Add info() #

Patch Set 4 : Add back support for numeric IP host #

Patch Set 5 : remove upload.py added by error, limit stack length to 4096 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -11 lines)			Patch
M	breakpad.py	View	1 2 3 4	2 chunks	+30 lines, -8 lines	0 comments	Download
M	gclient_utils.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	pylintrc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages