Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 53029: Propagate CC, CXX variables to Webcore and v8 (Closed)

Created:
11 years, 9 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, sgk
CC:
chromium-reviews_googlegroups.com, tony
Visibility:
Public.

Description

Propagate CC, CXX variables to Webcore and v8. I realize this will all go away Any Day Now. Until then, we can speed things up a bit more. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12425

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/SConscript.main View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
11 years, 9 months ago (2009-03-24 23:25:24 UTC) #1
Evan Martin
http://codereview.chromium.org/53029/diff/1/2 File build/SConscript.v8 (right): http://codereview.chromium.org/53029/diff/1/2#newcode32 Line 32: '-j %d ' % GetOption('num_jobs')), We had had ...
11 years, 9 months ago (2009-03-24 23:30:08 UTC) #2
Lei Zhang
Aww, we're down to a 1 line change now.
11 years, 9 months ago (2009-03-24 23:36:51 UTC) #3
Evan Martin
11 years, 9 months ago (2009-03-25 00:35:50 UTC) #4
On 2009/03/24 23:36:51, Lei Zhang wrote:
> Aww, we're down to a 1 line change now.

LGTM

Powered by Google App Engine
This is Rietveld 408576698