Issue 5302004: Fix the process sample to actually dispose the contexts used for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5302004: Fix the process sample to actually dispose the contexts used for (Closed)

Created:
10 years, 1 month ago by Mads Ager (chromium)

Modified:
10 years, 1 month ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix the process sample to actually dispose the contexts used for processors. Committed: http://code.google.com/p/v8/source/detail?r=5882

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	samples/process.cc	View		2 chunks	+8 lines, -10 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/5302004/diff/1/samples/process.cc File samples/process.cc (right): http://codereview.chromium.org/5302004/diff/1/samples/process.cc#newcode157 samples/process.cc:157: // returns a persistent handle which is what ...

10 years, 1 month ago (2010-11-24 09:18:42 UTC) #2

Mads Ager (chromium)

10 years, 1 month ago (2010-11-24 09:20:18 UTC) #3

http://codereview.chromium.org/5302004/diff/1/samples/process.cc
File samples/process.cc (right):

http://codereview.chromium.org/5302004/diff/1/samples/process.cc#newcode157
samples/process.cc:157: // returns a persistent handle which is what we need for
the
On 2010/11/24 09:18:43, Rico wrote:
> what does "ignore the first three lines" mean here?

Good point. I honestly don't know. I'll remove the comment.

Expand Messages | Collapse Messages