Working stand-alone preparser.

Working stand-alone preparser.


BUG=
TEST=

[ricow1, 2010-11-24 09:09:32]

LGTM, you could add a few additional comments on the classes and methods defined
in preparser-process.cc - but assuming that this prof-of-concept implementation
will change it is probably fine for now.

http://codereview.chromium.org/5302003/diff/1/preparser/preparser-process.cc
File preparser/preparser-process.cc (right):

http://codereview.chromium.org/5302003/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:28: #include <stdio.h>
stdio.h included through ../include/v8stdint.h

http://codereview.chromium.org/5302003/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:116: 
Add comment similar to ReadUInt32

http://codereview.chromium.org/5302003/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:155: int PreParseIO() {
What is the meaning of the exit values? Are these defined somewhere? If so,
maybe add a comment about where to find them

http://codereview.chromium.org/5302003/diff/1/src/v8checks.h
File src/v8checks.h (right):

http://codereview.chromium.org/5302003/diff/1/src/v8checks.h#newcode29
src/v8checks.h:29: #define V8_CHECKS_H_
This is the same ifndef test as in checks.h, I guess this would be:
#ifndef V8_V8_CHECKS_H_

[Lasse Reichstein, 2010-11-24 09:39:47]

http://codereview.chromium.org/5302003/diff/1/preparser/preparser-process.cc
File preparser/preparser-process.cc (right):

http://codereview.chromium.org/5302003/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:28: #include <stdio.h>
Removed.

http://codereview.chromium.org/5302003/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:116: 
Done.

http://codereview.chromium.org/5302003/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:155: int PreParseIO() {
No big meaning. 1 is error reading, 2 is error writing, and all that happens is
that they are written to stderr before exiting (for debugging purposes). I'll
give them more meaningful names.

http://codereview.chromium.org/5302003/diff/1/src/v8checks.h
File src/v8checks.h (right):

http://codereview.chromium.org/5302003/diff/1/src/v8checks.h#newcode29
src/v8checks.h:29: #define V8_CHECKS_H_
Good catch. Fixed.

[Lasse Reichstein, 2010-11-24 09:41:16]

I have added a big "THIS IS PROOF-OF-CONCEPT CODE" to the preparser-process
file.
I will also add the preparser dir to the presubmit checker.