Issue 5301006: [Mac] Prevent constrained windows (sheets) from opening while instant preview...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5301006: [Mac] Prevent constrained windows (sheets) from opening while instant preview... (Closed)

Created:
10 years ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Prevent constrained windows (sheets) from opening while instant preview results are showing. The sheet will be shown when instant results are committed, either by mouse click or by pressing enter. If the instant results are destroyed, the sheet is never made visible. BUG=61373 TEST=Enable instant. Paste in a URL that opens an http auth sheet. The sheet should not be visible. No crashy, either. Press enter. The sheet should show. TEST=Enable instant. Paste in a URL that opens an http auth sheet, then delete the last character. Some sort of instant results should load, most likely a 404 page. Retype the last character. 404 page will continue to show, but the sheet will not open. Click on the preview. The sheet should show. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67712

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
M	chrome/browser/cocoa/browser_window_controller.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.mm	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/constrained_window_mac.mm	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

For now, I'm just going to prevent the sheets from showing at all when they ...

10 years ago (2010-11-29 21:25:56 UTC) #1

LG

Expand Messages | Collapse Messages

Issue 5301006: [Mac] Prevent constrained windows (sheets) from opening while instant preview... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages