Issue 53002: Fix issue 284....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53002: Fix issue 284.... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix issue 284. The problem was continuing out of the body of a for/in (where we do register allocation) to the loop update (where we do not). Variables allocated to registers where not preserved. Committed: http://code.google.com/p/v8/source/detail?r=1585

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -41 lines)			Patch
M	src/codegen-arm.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
D	test/mjsunit/bugs/bug-284.js	View	1 chunk	+0 lines, -37 lines	0 comments	Download
A	test/mjsunit/regress/regress-284.js	View	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages