net: Add namespace net to URLRequest and URLRequestJob classes.

net: Add namespace net to URLRequest and URLRequestJob classes.

BUG=64263
TEST=compiled locally and trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67497

[tfarina, 2010-11-27 22:38:54]

Please, take a look.

[willchan no longer on Chromium, 2010-11-28 05:05:43]

Awesome!  LGTM.

On Sat, Nov 27, 2010 at 2:38 PM, <tfarina@chromium.org> wrote:

> Reviewers: willchan, wtc,
>
> Message:
> Please, take a look.
>
> Description:
> net: Add namespace net to URLRequest and URLRequestJob classes.
>
> BUG=64263
> TEST=compiled locally and trybots
>
> Please review this at http://codereview.chromium.org/5298008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/appcache/view_appcache_internals_job_factory.h
>  M chrome/browser/automation/url_request_automation_job.h
>  M chrome/browser/chromeos/login/registration_screen.h
>  M chrome/browser/debugger/devtools_netlog_observer.h
>  M chrome/browser/dom_ui/chrome_url_data_manager.h
>  M chrome/browser/dom_ui/chrome_url_data_manager.cc
>  M chrome/browser/dom_ui/shared_resources_data_source.h
>  M chrome/browser/extensions/user_script_listener.h
>  M chrome/browser/login_prompt.h
>  M chrome/browser/net/connect_interceptor.h
>  M chrome/browser/net/connect_interceptor.cc
>  M chrome/browser/net/load_timing_observer.h
>  M chrome/browser/net/metadata_url_request.cc
>  M chrome/browser/net/prerender_interceptor.h
>  M chrome/browser/net/prerender_interceptor.cc
>  M chrome/browser/net/url_request_failed_dns_job.h
>  M chrome/browser/net/url_request_slow_download_job.h
>  M chrome/browser/net/url_request_tracking.h
>  M chrome/browser/net/view_blob_internals_job_factory.h
>  M chrome/browser/net/view_http_cache_job_factory.h
>  M chrome/browser/net/view_http_cache_job_factory.cc
>  M chrome/browser/renderer_host/buffered_resource_handler.h
>  M chrome/browser/renderer_host/download_resource_handler.h
>  M chrome/browser/renderer_host/download_throttling_resource_handler.h
>  M chrome/browser/renderer_host/offline_resource_handler.h
>  M chrome/browser/renderer_host/resource_queue.h
>  M chrome/browser/renderer_host/resource_request_details.h
>  M chrome/browser/renderer_host/x509_user_cert_resource_handler.h
>  M chrome/browser/ssl/ssl_add_cert_handler.h
>  M chrome/browser/ssl/ssl_cert_error_handler.h
>  M chrome/browser/ssl/ssl_client_auth_handler.h
>  M chrome/browser/ssl/ssl_error_handler.h
>  M chrome/browser/ssl/ssl_manager.h
>  M chrome/browser/sync/glue/http_bridge.h
>  M chrome/browser/task_manager/task_manager.h
>  M chrome/common/net/url_request_intercept_job.h
>  M chrome_frame/test/net/test_automation_provider.h
>  M net/url_request/url_request.h
>  M net/url_request/url_request_context.h
>  M net/url_request/url_request_data_job.h
>  M net/url_request/url_request_error_job.h
>  M net/url_request/url_request_error_job.cc
>  M net/url_request/url_request_file_dir_job.h
>  M net/url_request/url_request_filter.h
>  M net/url_request/url_request_filter.cc
>  M net/url_request/url_request_ftp_job.h
>  M net/url_request/url_request_http_job.h
>  M net/url_request/url_request_job.h
>  M net/url_request/url_request_job_manager.h
>  M net/url_request/url_request_job_tracker.h
>  M net/url_request/url_request_redirect_job.h
>  M net/url_request/url_request_redirect_job.cc
>  M net/url_request/url_request_simple_job.h
>  M net/url_request/url_request_simple_job.cc
>  M net/url_request/url_request_test_job.h
>  M webkit/appcache/appcache_host.h
>  M webkit/appcache/appcache_interceptor.h
>  M webkit/appcache/appcache_interfaces.h
>  M webkit/appcache/appcache_request_handler.h
>  M webkit/appcache/appcache_url_request_job.h
>  M webkit/appcache/view_appcache_internals_job.h
>  M webkit/blob/blob_url_request_job.h
>  M webkit/blob/view_blob_internals_job.h
>  M webkit/fileapi/file_system_operation.h
>
>
>

[wtc, 2010-11-30 01:51:52]

LGTM.  Thanks!  I suggest some minor changes below.

http://codereview.chromium.org/5298008/diff/9001/chrome/browser/dom_ui/shared...
File chrome/browser/dom_ui/shared_resources_data_source.h (right):

http://codereview.chromium.org/5298008/diff/9001/chrome/browser/dom_ui/shared...
chrome/browser/dom_ui/shared_resources_data_source.h:12: class URLRequest;
It seems that this header file doesn't need any of the
three forward declarations.  Can you see if they can be
simply removed?

http://codereview.chromium.org/5298008/diff/9001/net/url_request/url_request.h
File net/url_request/url_request.h (right):

http://codereview.chromium.org/5298008/diff/9001/net/url_request/url_request....
net/url_request/url_request.h:46: typedef std::vector<std::string>
ResponseCookies;
It seems that we should also move FilePath,
URLRequestContext, and ResponseCookies into the 'net'
namespace.

http://codereview.chromium.org/5298008/diff/9001/net/url_request/url_request_...
File net/url_request/url_request_job.h (right):

http://codereview.chromium.org/5298008/diff/9001/net/url_request/url_request_...
net/url_request/url_request_job.h:45: explicit URLRequestJob(net::URLRequest*
request);
Don't need to add net:: to URLRequest because most of this
file is inside the 'net' namespace.

http://codereview.chromium.org/5298008/diff/9001/webkit/appcache/appcache_req...
File webkit/appcache/appcache_request_handler.h (right):

http://codereview.chromium.org/5298008/diff/9001/webkit/appcache/appcache_req...
webkit/appcache/appcache_request_handler.h:15: class URLRequestJob;
Nit: we should not need the forward declaration of
URLRequestJob.