remoting/host/event_executor.h - Issue 5298001: Use VP8 over PseudoTCP by default.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/event_executor.h

Issue 5298001: Use VP8 over PseudoTCP by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updated service_process.cc Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_HOST_EVENT_EXECUTOR_H_

	6 #define REMOTING_HOST_EVENT_EXECUTOR_H_

	7

	8 #include "remoting/protocol/input_stub.h"

	9

	10 class MessageLoop;

	11

	12 namespace remoting {

	13

	14 class Capturer;

	15

	16 // Base class for event executors.

	17 class EventExecutor : public protocol::InputStub {
	Alpha Left Google 2010/11/23 00:38:25 We'll make EventExecutor go away so create a stati We'll make EventExecutor go away so create a static factory method defined in event_executor.h but no need define a new class. Sergey Ulanov 2010/11/23 01:59:18 I think it is still better to have EventExecutor c Show quoted text On 2010/11/23 00:38:25, Alpha wrote: > We'll make EventExecutor go away so create a static factory method defined in > event_executor.h but no need define a new class. I think it is still better to have EventExecutor class: 1. It shows that EventExecutorWin, EventExecutorLinux and EventExecutorMac are related to each other. 2. We may need to add some other methods in here that are not part of InputStub. 3. It might be necessary to share some implementation details between different event executors (e.g. event queuing). 4. EventExecutor::Create() looks better than CreateEventExecutor(). Alpha Left Google 2010/11/23 05:15:24 I suggest we add such class when we need it. Right Show quoted text On 2010/11/23 01:59:18, sergeyu wrote: > On 2010/11/23 00:38:25, Alpha wrote: > > We'll make EventExecutor go away so create a static factory method defined in > > event_executor.h but no need define a new class. > > I think it is still better to have EventExecutor class: > 1. It shows that EventExecutorWin, EventExecutorLinux and EventExecutorMac are > related to each other. > 2. We may need to add some other methods in here that are not part of > InputStub. > 3. It might be necessary to share some implementation details between different > event executors (e.g. event queuing). > 4. EventExecutor::Create() looks better than CreateEventExecutor(). I suggest we add such class when we need it. Right now I still don't see what is needed more than this just the InputStub interface. And it is supposed to just implement the InputStub interface..
	18 public:

	19 static EventExecutor* Create(MessageLoop* message_loop, Capturer* capturer);

	20 };

	21

	22 } // namespace remoting

	23

	24 #endif // REMOTING_HOST_EVENT_EXECUTOR_H_

OLD	NEW

« no previous file with comments | « remoting/host/chromoting_host.cc ('k') | remoting/host/event_executor_linux.h » ('j') | no next file with comments »