Issue 5292013: GTK: Parse NETSCAPE_URL types in drags to the bookmark bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5292013: GTK: Parse NETSCAPE_URL types in drags to the bookmark bar. (Closed)

Created:
10 years ago by Elliot Glaysher

Modified:
5 years, 6 months ago

Reviewers:
sky, Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

GTK: Parse NETSCAPE_URL types in drags to the bookmark bar. This allows us to keep the original Firefox title of the bookmark. BUG=34375 TEST=Drag a bookmark from the Firefox bookmark bar to the Chrome bookmark bar. It should maintain the title instead of turning to the filename/url. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67872

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -0 lines)			Patch
M	app/gtk_dnd_util.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	app/gtk_dnd_util.cc	View	1 chunk	+23 lines, -0 lines	2 comments	Download
M	chrome/browser/gtk/bookmark_bar_gtk.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_utils_gtk.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_utils_gtk.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/5292013/diff/1/app/gtk_dnd_util.cc File app/gtk_dnd_util.cc (right): http://codereview.chromium.org/5292013/diff/1/app/gtk_dnd_util.cc#newcode258 app/gtk_dnd_util.cc:258: *url = gurl; if (url) ... if (title) ...

10 years ago (2010-11-30 23:56:17 UTC) #2

Elliot Glaysher

10 years ago (2010-12-01 00:05:21 UTC) #4

http://codereview.chromium.org/5292013/diff/1/app/gtk_dnd_util.cc
File app/gtk_dnd_util.cc (right):

http://codereview.chromium.org/5292013/diff/1/app/gtk_dnd_util.cc#newcode258
app/gtk_dnd_util.cc:258: *url = gurl;
On 2010/11/30 23:56:17, Evan Stade wrote:
> if (url)
> ...
> 
> if (title)
> ...

ExtractNamedURL() and ExtractURIList() don't check them. They out parameters are
not optional.

Expand Messages | Collapse Messages