Issue 5292010: Cleanup...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5292010: Cleanup... (Closed)

Created:
10 years ago by nfullagar

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup - change comment style in ppb_audio_trusted_dev.h to c style - change shm_size to uint32_t to match other interfaces BUG=none TEST=src/ppapi/examples/audio/audio.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67730

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -18 lines)			Patch
M	ppapi/c/dev/ppb_audio_trusted_dev.h	View	1 2	1 chunk	+23 lines, -15 lines	0 comments	Download
M	webkit/glue/plugins/pepper_audio.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_audio.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nfullagar

10 years ago (2010-11-30 18:54:12 UTC) #3

thx, committed as r67730

On Mon, Nov 29, 2010 at 8:57 PM, <brettw@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/5292010/
>

Expand Messages | Collapse Messages