Issue 5292003: Some cosmetic fixups to the device management service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5292003: Some cosmetic fixups to the device management service. (Closed)

Created:
10 years ago by Mattias Nissler (ping if slow)

Modified:
9 years, 7 months ago

Reviewers:
markusheintz_

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Some cosmetic fixups to the device management service. This renames DeviceManagementBackendRequestContext(Getter) to DeviceManagementRequestContext(Getter), actually instantiates it and updates a comment. BUG=63608 TEST=compiles and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67114

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
	M	chrome/browser/policy/device_management_service.cc	View		5 chunks	+12 lines, -14 lines	0 comments	Download
	M	chrome/browser/profile.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

Markus, here are some follow-up fixes to the DeviceManagementService CL.

10 years ago (2010-11-23 16:18:27 UTC) #1

markusheintz_

10 years ago (2010-11-23 16:25:00 UTC) #3

On 2010/11/23 16:23:36, markusheintz_ wrote:
> LGTM
If the try bot runs cycle green.

Expand Messages | Collapse Messages