Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 5291010: [cros] Make sure that update screen will be skipped when shortcut is pressed. (Closed)

Created:
10 years ago by Nikita (slow)
Modified:
9 years, 7 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[cros] Make sure that update screen will be skipped when shortcut is pressed. See same commit to trunk http://codereview.chromium.org/5366004/ update_screen has been changed significantly there (added non-critical updates). BUG=chromium-os:9654 TEST=Manual, tested on cros using branch version of Chrome. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M chrome/browser/chromeos/login/update_screen.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/update_screen.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nikita (slow)
10 years ago (2010-11-30 17:18:08 UTC) #1
Dmitry Polukhin
10 years ago (2010-11-30 17:25:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698