Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Unified Diff: scm.py

Issue 529002: Abort gclient sync when a svn command fails. (Closed)
Patch Set: typo Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scm.py
diff --git a/scm.py b/scm.py
index 42a764c9023904bb975734ea560edaf03da56608..3481219ba831fd9ed862c350a72c7e8c5b459c3c 100644
--- a/scm.py
+++ b/scm.py
@@ -333,6 +333,7 @@ class SVN(object):
for i in range(1, 10):
previous_list_len = len(file_list)
failure = []
+
def CaptureMatchingLines(line):
match = compiled_pattern.search(line)
if match:
@@ -341,6 +342,7 @@ class SVN(object):
# We can't raise an exception. We can't alias a variable. Use a cheap
# way.
failure.append(True)
+
try:
SVN.RunAndFilterOutput(args,
in_directory,
@@ -355,6 +357,8 @@ class SVN(object):
# An aborted checkout is now an update.
args[0] = 'update'
continue
+ # No progress was made, bail out.
+ raise
break
@staticmethod
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698