Use the correct signal to detect failed navigations

chrome/browser/tab_contents/tab_contents.cc

Index: chrome/browser/tab_contents/tab_contents.cc
diff --git a/chrome/browser/tab_contents/tab_contents.cc b/chrome/browser/tab_contents/tab_contents.cc
index 6ec6ba34332303468e641388883569d82d954306..f257b23db9e29ec2fe4e03c8efad57785af03444 100644
--- a/chrome/browser/tab_contents/tab_contents.cc
+++ b/chrome/browser/tab_contents/tab_contents.cc
@@ -2143,7 +2143,8 @@ void TabContents::DidStartProvisionalLoadForFrame(
     const GURL& url) {
   ProvisionalLoadDetails details(is_main_frame,
                                  controller_.IsURLInPageNavigation(url),
-                                 url, std::string(), false, frame_id);
+                                 url, std::string(), false,
+                                 is_error_page, frame_id);
   NotificationService::current()->Notify(
       NotificationType::FRAME_PROVISIONAL_LOAD_START,
       Source<NavigationController>(&controller_),
@@ -2252,7 +2253,7 @@ void TabContents::DidFailProvisionalLoadWithError(
   // Send out a notification that we failed a provisional load with an error.
   ProvisionalLoadDetails details(is_main_frame,
                                  controller_.IsURLInPageNavigation(url),
-                                 url, std::string(), false, frame_id);
+                                 url, std::string(), false, false, frame_id);

[yzshen, 2010/12/01 18:21:53]

I am not sure I understand this correctly.

Is FRAME_PROVISIONAL_LOAD_START the only event that carries a valid
is_error_page field?

[Matt Perry, 2010/12/01 20:51:10]

I'm also a little confused. Do we not get a "committed" event for the error
page?

   details.set_error_code(error_code);
 
   NotificationService::current()->Notify(
@@ -2492,7 +2493,7 @@ void TabContents::DidNavigate(RenderViewHost* rvh,
     bool is_main_frame = did_navigate ? details.is_main_frame : false;
     ProvisionalLoadDetails load_details(
         is_main_frame, details.is_in_page, params.url, std::string(), false,
-        params.frame_id);
+        false, params.frame_id);
     load_details.set_transition_type(params.transition);
     // Whether or not a page transition was triggered by going backward or
     // forward in the history is only stored in the navigation controller's