Issue 5290003: Add pyauto tests for HTML5 notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5290003: Add pyauto tests for HTML5 notifications. (Closed)

Created:
10 years, 1 month ago by kkania

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, John Grabowski, anantha, Nirnimesh, dyu1, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/test/functional

Visibility:
Public.

Description

Add pyauto tests for HTML5 notifications. BUG=63852 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68264

Patch Set 1 : ... #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -12 lines)			Patch
	M	chrome/test/data/notifications/notification_tester.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/test/functional/notifications.py	View		9 chunks	+235 lines, -12 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kkania

This should be the last of the email tests related to my new features.

10 years, 1 month ago (2010-11-24 18:36:08 UTC) #1

Nirnimesh

10 years, 1 month ago (2010-11-24 23:02:59 UTC) #2

LGTM

http://codereview.chromium.org/5290003/diff/2001/chrome/test/functional/notif...
File chrome/test/functional/notifications.py (right):

http://codereview.chromium.org/5290003/diff/2001/chrome/test/functional/notif...
chrome/test/functional/notifications.py:197:
self.CallJavascriptFunc('requestPermission', [], tab_index, windex)
Use named args whenever possible to avoid these problems.

http://codereview.chromium.org/5290003/diff/2001/chrome/test/functional/notif...
chrome/test/functional/notifications.py:472:
self._CreateHTMLNotification(self.NO_SUCH_URL)
Why is this line needed?

Expand Messages | Collapse Messages